TIDO-508 Add extracted test SAML Attributes to proxy #4
+41
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshafer
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Could we rename the headers from "X-Forwarded-*" to "Shib-Proxy-{attributeName}"? For instance:
RequestHeader unset Shib-Proxy-displayName
RequestHeader unset Shib-Proxy-eppn
RequestHeader unset Shib-Proxy-mail
A couple reasons:
- RFC 6648 deprecated the "X-" prefix for custom HTTP headers. Instead we're just supposed to pick a sensible prefix (e.g. "Shib-Proxy-").
- As we pass more attributes through the proxy, it could get confusing if the attribute names in the headers don't match the SAML attribute names (Email vs. mail, DisplayName vs. displayName, User vs. eppn, etc.).
There was a problem hiding this comment.
I think this file contained customizations at one point, but they weren't needed anymore after you updated the attribute name format. Now the only changes look like they're changes in whitespace. Could we remove this file, and just use the version from the base image?
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.